LDRA Testbed ® Code Review Report

Group : PVM-hoster






Overall Result: FAIL






Report Production Report Configuration Analysis phases
  • C/C++ LDRA Testbed Version: 8.1.0
  • Config. File: C:\Testbed_CCPP_810\c\creport.dat
  • Produced On: Thu Sep 03 2009 at 13:55:20
  • Penalty File: C:\Testbed_CCPP_810\c\cpen.dat
  • Report Level: Summary Report
  • Procedures Reported: Fails Only
  • Programming Standards Model: CERT
  • Line Numbers refer to: Original Source File
  • Violation Details: Violations Only
  • Reporting Scope: Full analysis scope
  • Static: Yes
  • Complexity: No
  • Static Data Flow: No
  • Information Flow: No
  • Cross Reference: No


Contents

Overall Quality Summary
Report on Program Components
Key to Terms





Overall Quality Summary



Totals of Violations for Selected Quality Standards

'-' indicates required Analysis Phase results are not yet available.
'Off' indicates that the standard is switched off in the Penalty File (<lang>pen.dat).
'MR'indicates that the standard is Misra Restricted.

Number of Violations LDRA Code (M) Mandatory Standards CERT Code
30
9 S CERT PRE31-C,EXP30-C,EXP31-C,FIO41-C
0
20 S CERT DCL31-C
8
30 S CERT EXP30-C,EXP31-C
-
5 D CERT EXP33-C
0
39 S CERT FLP30-C
0
43 S CERT ENV33-C,SIG32-C
0
47 S CERT ARR30-C
1
71 S CERT DCL30-C,MEM36-C
0
86 S CERT ERR31-C
27
93 S CERT INT01-C,INT02-C,INT07-C
12
94 S CERT EXP11-C,EXP36-C,INT11-C
1
98 S CERT EXP37-C
-
17 D CERT DCL32-C
-
19 D CERT EXP37-C
-
20 D CERT DCL31-C,ERR30-C
-
24 D CERT DCL31-C
-
1 X CERT ARR31-C
0
134 S CERT EXP10-C,EXP30-C
-
35 D CERT EXP02-C,EXP10-C,EXP30-C
0
1 Q CERT EXP02-C,EXP10-C,EXP30-C
16
157 S CERT STR05-C,STR30-C
325
170 S CERT DCL07-C,EXP37-C
-
41 D CERT EXP37-C
-
42 D CERT DCL30-C
-
43 D CERT INT32-C,INT33-C
0
248 S CERT INT33-C
-
45 D CERT EXP08-C,EXP34-C
-
49 D CERT FIO42-C
4
326 S CERT DCL31-C
0
344 S CERT EXP32-C
-
51 D CERT MEM30-C
0
355 S CERT DCL32-C
0
403 S CERT INT34-C
0
433 S CERT INT02-C,INT31-C
4
434 S CERT INT02-C,INT31-C,STR34-C
0
442 S CERT INT02-C,FLP33-C
0
443 S CERT INT02-C,FLP33-C
0
444 S CERT FLP33-C
0
456 S CERT MSC31-C
-
57 D CERT EXP33-C
20
476 S CERT ARR30-C
0
480 S CERT DCL33-C
1
483 S CERT MEM34-C
0
484 S CERT MEM31-C
0
487 S CERT MEM35-C
0
489 S CERT DCL33-C,FIO43-C
0
493 S CERT INT32-C
0
494 S CERT INT32-C
174
496 S CERT EXP37-C
-
61 X CERT DCL32-C

Number of Violations LDRA Code (M) Mandatory Standards CERT Code
-
64 X CERT ARR30-C
-
69 D CERT EXP33-C
0
562 S Use of ++,-- or = in macro parameters. CERT PRE31-C
-
75 D CERT FIO31-C
-
68 X CERT DCL00-C
-
69 X CERT ARR30-C
0
573 S Macro concatenation of uni char names. CERT PRE30-C
0
575 S Linkage differs from previous declaration. CERT DCL36-C
0
576 S Function pointer is of wrong type. CERT DCL35-C,EXP08-C


Number of Violations LDRA Code (C) Checking (Mandatory) Standards CERT Code

No Standards have been set as Checking.

Number of Violations LDRA Code (O) Optional Standards CERT Code
0
5 S CERT MSC03-C
42 12 S CERT MSC01-C
0
21 S CERT DCL07-C
-
1 D CERT MSC13-C
-
4 D CERT MSC13-C
-
7 D CERT MSC13-C
-
8 D CERT MSC08-C
-
15 D CERT MSC13-C
0
41 S CERT DCL10-C,DCL11-C
35 44 S CERT DCL03-C,INT06-C
0
50 S CERT INT13-C
0
52 S CERT INT02-C
0
54 S CERT EXP06-C
0
57 S CERT MSC03-C,MSC12-C
11 58 S CERT MSC03-C
0
59 S CERT MSC03-C
0
73 S CERT INT12-C
9 79 S CERT PRE03-C
0
81 S CERT PRE07-C
0
85 S CERT INT09-C
3 95 S CERT EXP11-C
0
99 S CERT MSC02-C
1 101 S CERT INT02-C
-
27 D CERT DCL15-C
22 113 S CERT MSC09-C
11 77 S CERT PRE02-C
10 78 S CERT PRE01-C,PRE02-C
9 96 S CERT INT02-C
0
115 S CERT STR03-C
0
119 S CERT MSC04-C
8 120 S CERT INT13-C
0
125 S CERT PRE05-C
1 131 S CERT DCL01-C
21 132 S CERT MSC02-C
0
133 S CERT EXP02-C
6 135 S CERT DCL07-C
0
139 S CERT MSC07-C
0
140 S CERT MSC07-C
0
176 S CERT MSC10-C
14 177 S CERT DCL04-C
4 200 S CERT DCL00-C
237 201 S CERT DCL06-C,EXP07-C,EXP09-C
0
203 S CERT EXP05-C
0
218 S CERT PRE04-C
1 243 S CERT PRE06-C
27 273 S CERT PRE03-C
0
299 S CERT DCL05-C
0
1 J CERT MSC07-C
1 302 S CERT MSC04-C
0
329 S CERT INT07-C

Number of Violations LDRA Code (O) Optional Standards CERT Code
19 331 S CERT INT13-C
0
332 S CERT INT02-C
0
334 S CERT INT02-C
6 340 S CERT PRE00-C
2 352 S CERT DCL12-C
-
50 D CERT MEM00-C
27 361 S CERT EXP00-C
1 376 S CERT MSC10-C
2 381 S CERT DCL05-C
13 382 S CERT EXP12-C
-
53 D CERT EXP08-C
0
387 S CERT DCL08-C
23 400 S CERT EXP03-C
1 401 S CERT ARR00-C
0
406 S CERT EXP02-C
-
54 D CERT EXP08-C
0
408 S CERT EXP02-C
0
432 S CERT INT07-C
0
438 S CERT EXP08-C
0
439 S CERT INT15-C
0
440 S CERT INT15-C
0
446 S CERT INT02-C
0
452 S CERT INT02-C
0
457 S CERT INT02-C
1 458 S CERT INT02-C,INT07-C
0
486 S CERT FIO00-C
0
488 S CERT INT08-C
0
491 S CERT INT02-C
-
61 D CERT DCL15-C
-
62 D CERT DCL13-C
0
515 S CERT DCL04-C
-
65 D CERT MSC12-C
-
70 D CERT MSC12-C
0
553 S Function and proto should both be static. CERT DCL15-C
-
72 D CERT EXP10-C
-
67 X CERT DCL02-C
-
74 D CERT EXP10-C
0
568 S #include "filename" uses standard library name. CERT PRE04-C
7 577 S Sizeof argument is a pointer. CERT EXP01-C
14 578 S Sizeof used in arithmetic expression. CERT EXP03-C
-
78 D CERT DCL00-C
0
584 S Remainder of % op could be negative. CERT INT10-C
2 585 S Bitwise and arith operations on same data. CERT INT14-C
0
586 S Format is not %j for user defined type. CERT INT15-C


Number of Mandatory Standards checked 39
Number of Checking Standards checked 0
Number of Optional Standards checked 77
Total Standards checked 116






OVERALL RESULT: FAIL




Out of 27 program components, 1 (3.70 %) passes ( of which 1 conditionally passes ) and 26 fail ( of which 0 fail only because of insufficient comments )

Procedure Results

Quality Result   Procedure   Source File   Unique Violations    
           
Conditional Pass Global Program
FAIL main hoster.c 5 -
FAIL hoster hoster.c 8 -
FAIL close_slot hoster.c 4 -
FAIL pl_startup hoster.c 11 -
FAIL phase1 hoster.c 9 -
FAIL rexec pvmwinrexec.c 5 -
FAIL GetPassword pvmwinrexec.c 5 -
FAIL PassOutput pvmwinrexec.c 2 -
FAIL PassOutputThread pvmwinrexec.c 7 -
FAIL PassError pvmwinrexec.c 2 -
FAIL PassErrorThread pvmwinrexec.c 4 -
FAIL MyOpenService pvmwinrexec.c 4 -
FAIL Cleanup pvmwinrexec.c 1 -
FAIL SendZString pvmwinrexec.c 2 -
FAIL GetErrString pvmwinrexec.c 2 -
FAIL rresvport pvmwinrsh.c 3 -
FAIL sendsocket pvmwinrsh.c 2 -
FAIL receivesocket pvmwinrsh.c 6 -
FAIL verify_hostname pvmwinrsh.c 2 -
FAIL initSocket pvmwinrsh.c 4 -
FAIL initErrSocket pvmwinrsh.c 3 -
FAIL do_command pvmwinrsh.c 2 -
FAIL clientThread pvmwinrsh.c 2 -
FAIL th_start pvmwinrsh.c 2 -
FAIL th_stop pvmwinrsh.c 2 -
FAIL rsh pvmwinrsh.c 3 -


Global Information

Source Files in Group

Name Last Modification Date
D:\Code\SAMATE\SATE2009\sate2009_C_test_cases\c\pvm\pvm3\hoster\pvmwinrsh.c Mon Mar 15 14:52:03 1999
D:\Code\SAMATE\SATE2009\sate2009_C_test_cases\c\pvm\pvm3\hoster\pvmwinrexec.c Tue Feb 04 13:06:31 2003
D:\Code\SAMATE\SATE2009\sate2009_C_test_cases\c\pvm\pvm3\hoster\hoster.c Wed May 18 10:55:41 2005




Global Basic Information

Number of procedures: 26
Number of locally uncalled procedures: 0
Number of reformatted executable lines: 1879
Number of lines of comments: 252



Summary Report on all Program Components



Globals / code outside procedures - Conditional Pass

Standards Violation Summary - All files

Code File: Src Line Violation Standard
O hoster.c: 3 Non standard character $ in source. CERT MSC09-C
O hoster.c: 58 Found #define. CERT PRE03-C
O hoster.c: 61 Found #define. CERT PRE03-C
O hoster.c: 61 Macro parameter not in brackets. CERT PRE01-C,PRE02-C
O hoster.c: 61 Macro replacement list needs parentheses. CERT PRE02-C
O hoster.c: 65 Included file not protected with #define. CERT PRE06-C
O bfunc.h: 63 Found #define. CERT PRE03-C
O bfunc.h: 64 Found #define. CERT PRE03-C
O bfunc.h: 65 Found #define. CERT PRE03-C
O bfunc.h: 68 Found #define. CERT PRE03-C
O bfunc.h: 68 Macro parameter not in brackets. CERT PRE01-C,PRE02-C
O bfunc.h: 68 Macro replacement list needs parentheses. CERT PRE02-C
O bfunc.h: 69 Found #define. CERT PRE03-C
O bfunc.h: 69 Macro parameter not in brackets. CERT PRE01-C,PRE02-C
O bfunc.h: 69 Macro replacement list needs parentheses. CERT PRE02-C
O bfunc.h: 70 Found #define. CERT PRE03-C
O bfunc.h: 70 Macro parameter not in brackets. CERT PRE01-C,PRE02-C
O bfunc.h: 70 Macro replacement list needs parentheses. CERT PRE02-C
O hoster.c: 72 Found #define. CERT PRE03-C
O hoster.c: 72 Define used for numeric constant. CERT DCL00-C
O hoster.c: 77 Found #define. CERT PRE03-C
O hoster.c: 77 Define used for numeric constant. CERT DCL00-C
O hoster.c: 81 Found #define. CERT PRE03-C
O hoster.c: 81 Use of function like macro. CERT PRE00-C
O hoster.c: 81 Macro contains unacceptable items CERT PRE03-C
O hoster.c: 85 Found #define. CERT PRE03-C
O hoster.c: 85 Use of function like macro. CERT PRE00-C
O hoster.c: 85 Macro contains unacceptable items CERT PRE03-C
O hoster.c: 89 Found #define. CERT PRE03-C
O hoster.c: 92 Found #define. CERT PRE03-C
O hoster.c: 92 Macro parameter not in brackets. CERT PRE01-C,PRE02-C
O hoster.c: 92 Use of banned function or variable. CERT DCL03-C,INT06-C
O hoster.c: 92 Use of function like macro. CERT PRE00-C
O hoster.c: 92 Macro contains unacceptable items CERT PRE03-C
O hoster.c: 93 Found #define. CERT PRE03-C
O hoster.c: 93 Use of banned function or variable. CERT DCL03-C,INT06-C
O hoster.c: 93 Macro parameter not in brackets. CERT PRE01-C,PRE02-C
O hoster.c: 93 Macro replacement list needs parentheses. CERT PRE02-C
O hoster.c: 94 Found #define. CERT PRE03-C
O hoster.c: 94 Macro parameter not in brackets. CERT PRE01-C,PRE02-C
O hoster.c: 94 Macro replacement list needs parentheses. CERT PRE02-C
O hoster.c: 94 Macro contains unacceptable items CERT PRE03-C
O hoster.c: 96 Found #define. CERT PRE03-C
O hoster.c: 96 Macro parameter not in brackets. CERT PRE01-C,PRE02-C
O hoster.c: 96 Macro replacement list needs parentheses. CERT PRE02-C
O hoster.c: 96 Macro contains unacceptable items CERT PRE03-C
O hoster.c: 98 Found #define. CERT PRE03-C
O hoster.c: 98 Macro parameter not in brackets. CERT PRE01-C,PRE02-C
O hoster.c: 98 Macro replacement list needs parentheses. CERT PRE02-C
O hoster.c: 98 Macro contains unacceptable items CERT PRE03-C

Code File: Src Line Violation Standard
O hoster.c: 100 Found #define. CERT PRE03-C
O hoster.c: 100 Macro parameter not in brackets. CERT PRE01-C,PRE02-C
O hoster.c: 100 Macro replacement list needs parentheses. CERT PRE02-C
O hoster.c: 100 Macro contains unacceptable items CERT PRE03-C
O hoster.c: 103 Found #define. CERT PRE03-C
O hoster.c: 103 Use of function like macro. CERT PRE00-C
O hoster.c: 105 Found #define. CERT PRE03-C
O hoster.c: 105 Use of function like macro. CERT PRE00-C
O hoster.c: 107 Found #define. CERT PRE03-C
O hoster.c: 107 Use of function like macro. CERT PRE00-C
O hoster.c: 111 Found #define. CERT PRE03-C
O hoster.c: 111 Macro replacement list needs parentheses. CERT PRE02-C
O hoster.c: 111 Macro contains unacceptable items CERT PRE03-C
O hoster.c: 119 Found #define. CERT PRE03-C
O hoster.c: 119 Macro replacement list needs parentheses. CERT PRE02-C
O hoster.c: 119 Macro contains unacceptable items CERT PRE03-C
O hoster.c: 132 Declaration of type not in header file. CERT DCL12-C
O hoster.c: 132 Enum, struct or union not typedeffed. CERT DCL05-C
O hoster.c: 138 Found #define. CERT PRE03-C
O hoster.c: 138 Define used for numeric constant. CERT DCL00-C
O hoster.c: 139 Found #define. CERT PRE03-C
O hoster.c: 139 Define used for numeric constant. CERT DCL00-C
O hoster.c: 146 Declaration of type not in header file. CERT DCL12-C
O hoster.c: 146 Enum, struct or union not typedeffed. CERT DCL05-C
O hoster.c: 147 Identifier not declared on new line. CERT DCL04-C
O hoster.c: 150 Identifier not declared on new line. CERT DCL04-C
O hoster.c: 164 Use of banned function or variable. CERT DCL03-C,INT06-C
O pvmwinrexec.c: 3 Non standard character $ in source. CERT MSC09-C
O pvmwinrexec.c: 38 Found #define. CERT PRE03-C
O pvmwinrexec.c: 49 Parameter list is KR. CERT DCL07-C
O pvmwinrexec.c: 50 Parameter list is KR. CERT DCL07-C
O pvmwinrexec.c: 52 Identifier not declared on new line. CERT DCL04-C
O pvmwinrexec.c: 52 Identifier not declared on new line. CERT DCL04-C
O pvmwinrexec.c: 70 Use of banned function or variable. CERT DCL03-C,INT06-C
O pvmwinrsh.c: 3 Non standard character $ in source. CERT MSC09-C

[ Top of Report | Key to Terms | Procedure Table | Contents ]






main
(189 to 260 hoster.c) - FAIL

Standards Violation Summary

Code Line Violation Standard
M 201 Assignment operation in expression. CERT PRE31-C,EXP30-C,EXP31-C,FIO41-C
M 201 function call with no prior declaration. CERT EXP37-C
M 201 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 202 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 205 function call with no prior declaration. CERT EXP37-C
M 205 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 206 Assignment operation in expression. CERT PRE31-C,EXP30-C,EXP31-C,FIO41-C
M 206 function call with no prior declaration. CERT EXP37-C
M 206 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 207 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 207 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 207 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 209 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 210 function call with no prior declaration. CERT EXP37-C
M 210 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 213 function call with no prior declaration. CERT EXP37-C
M 213 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 214 function call with no prior declaration. CERT EXP37-C
M 214 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 215 function call with no prior declaration. CERT EXP37-C
M 215 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 218 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 221 function call with no prior declaration. CERT EXP37-C
M 221 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 232 function call with no prior declaration. CERT EXP37-C
M 254 function call with no prior declaration. CERT EXP37-C
M 254 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C


[ Top of Report | Key to Terms | Procedure Table | Contents ]






hoster
(269 to 371 hoster.c) - FAIL

Standards Violation Summary

Code Line Violation Standard
M 269 Declaration is missing type. CERT DCL31-C
M 289 function call with no prior declaration. CERT EXP37-C
M 289 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 290 function call with no prior declaration. CERT EXP37-C
M 290 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 291 function call with no prior declaration. CERT EXP37-C
M 291 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 293 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 295 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 297 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 298 Array index not unsigned. CERT ARR30-C
M 298 Value is not of appropriate type. : unsigned int int hostlist [ i CERT INT01-C,INT02-C,INT07-C
M 301 function call with no prior declaration. CERT EXP37-C
M 301 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 303 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 304 function call with no prior declaration. CERT EXP37-C
M 304 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 307 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 307 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 307 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 308 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 308 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 308 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 309 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 309 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 309 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 312 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 315 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 315 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 315 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 318 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 321 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 321 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 321 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 323 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 327 Assignment operation in expression. CERT PRE31-C,EXP30-C,EXP31-C,FIO41-C
M 327 function call with no prior declaration. CERT EXP37-C
M 327 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 328 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 328 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 328 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 329 Modification of string literal. CERT STR05-C,STR30-C
M 330 Modification of string literal. CERT STR05-C,STR30-C
M 330 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 330 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 330 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 331 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 338 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 340 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 349 function call with no prior declaration. CERT EXP37-C

Code Line Violation Standard
M 355 function call with no prior declaration. CERT EXP37-C
M 355 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 357 function call with no prior declaration. CERT EXP37-C
M 357 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 357 Array index not unsigned. CERT ARR30-C
M 357 Value is not of appropriate type. : unsigned int int pvm_packf ( "%d" , hostlist [ i CERT INT01-C,INT02-C,INT07-C
M 358 function call with no prior declaration. CERT EXP37-C
M 358 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 358 Array index not unsigned. CERT ARR30-C
M 358 Value is not of appropriate type. : unsigned int int pvm_packf ( "%s" , hostlist [ i CERT INT01-C,INT02-C,INT07-C
M 359 Array index not unsigned. CERT ARR30-C
M 359 Value is not of appropriate type. : unsigned int int hostlist [ i CERT INT01-C,INT02-C,INT07-C
M 365 function call with no prior declaration. CERT EXP37-C
M 365 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 367 function call with no prior declaration. CERT EXP37-C
M 367 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 368 function call with no prior declaration. CERT EXP37-C
M 368 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C


[ Top of Report | Key to Terms | Procedure Table | Contents ]






close_slot
(374 to 386 hoster.c) - FAIL

Standards Violation Summary

Code Line Violation Standard
M 374 Declaration is missing type. CERT DCL31-C
M 378 function call with no prior declaration. CERT EXP37-C
M 378 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 380 function call with no prior declaration. CERT EXP37-C
M 380 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 382 function call with no prior declaration. CERT EXP37-C
M 382 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 383 Assignment operation in expression. CERT PRE31-C,EXP30-C,EXP31-C,FIO41-C


[ Top of Report | Key to Terms | Procedure Table | Contents ]






pl_startup
(389 to 770 hoster.c) - FAIL

Standards Violation Summary

Code Line Violation Standard
M 389 Declaration is missing type. CERT DCL31-C
M 413 Assignment operation in expression. CERT PRE31-C,EXP30-C,EXP31-C,FIO41-C
M 415 Assignment operation in expression. CERT PRE31-C,EXP30-C,EXP31-C,FIO41-C
M 417 Array index not unsigned. CERT ARR30-C
M 417 Value is not of appropriate type. : unsigned int int ( & slots [ i CERT INT01-C,INT02-C,INT07-C
M 417 Array index not unsigned. CERT ARR30-C
M 417 Value is not of appropriate type. : unsigned int int ( & slots [ i CERT INT01-C,INT02-C,INT07-C
M 417 Array index not unsigned. CERT ARR30-C
M 417 Value is not of appropriate type. : unsigned int int ( slfree ) -> s_link -> s_rlink = ( & slots [ i CERT INT01-C,INT02-C,INT07-C
M 417 Array index not unsigned. CERT ARR30-C
M 417 Value is not of appropriate type. : unsigned int int ( slfree ) -> s_link = ( & slots [ i CERT INT01-C,INT02-C,INT07-C
M 435 Array index not unsigned. CERT ARR30-C
M 435 Deprecated usage of ++ or -- operators found. CERT EXP30-C,EXP31-C
M 435 Value is not of appropriate type. : unsigned int int hp = hostlist [ nxth ++ CERT INT01-C,INT02-C,INT07-C
M 440 Assignment operation in expression. CERT PRE31-C,EXP30-C,EXP31-C,FIO41-C
M 445 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 447 function call with no prior declaration. CERT EXP37-C
M 452 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 457 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 460 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 466 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 469 function call with no prior declaration. CERT EXP37-C
M 473 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 481 function call with no prior declaration. CERT EXP37-C
M 481 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 484 Assignment operation in expression. CERT PRE31-C,EXP30-C,EXP31-C,FIO41-C
M 495 function call with no prior declaration. CERT EXP37-C
M 495 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 498 Assignment operation in expression. CERT PRE31-C,EXP30-C,EXP31-C,FIO41-C
M 511 function call with no prior declaration. CERT EXP37-C
M 511 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 513 Assignment operation in expression. CERT PRE31-C,EXP30-C,EXP31-C,FIO41-C
M 514 function call with no prior declaration. CERT EXP37-C
M 514 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 517 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 520 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 520 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 520 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 530 function call with no prior declaration. CERT EXP37-C
M 530 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 534 function call with no prior declaration. CERT EXP37-C
M 534 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 547 Assignment operation in expression. CERT PRE31-C,EXP30-C,EXP31-C,FIO41-C
M 550 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 553 Assignment operation in expression. CERT PRE31-C,EXP30-C,EXP31-C,FIO41-C
M 553 function call with no prior declaration. CERT EXP37-C
M 553 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 553 Casting operation on a pointer. CERT EXP11-C,EXP36-C,INT11-C
M 564 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 566 function call with no prior declaration. CERT EXP37-C

Code Line Violation Standard
M 566 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 570 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 577 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 579 function call with no prior declaration. CERT EXP37-C
M 579 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 593 function call with no prior declaration. CERT EXP37-C
M 593 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 599 function call with no prior declaration. CERT EXP37-C
M 599 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 604 Value is not of appropriate type. : unsigned int int sp -> s_ebuf [ sp -> s_elen CERT INT01-C,INT02-C,INT07-C
M 620 Assignment operation in expression. CERT PRE31-C,EXP30-C,EXP31-C,FIO41-C
M 620 function call with no prior declaration. CERT EXP37-C
M 620 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 621 Modification of string literal. CERT STR05-C,STR30-C
M 622 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 627 function call with no prior declaration. CERT EXP37-C
M 627 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 628 Value is not of appropriate type. : unsigned int int sp -> s_ebuf [ sp -> s_elen CERT INT01-C,INT02-C,INT07-C
M 631 Value is not of appropriate type. : bool signed char sp -> s_elen == sizeof ( sp -> s_ebuf ) CERT INT01-C,INT02-C,INT07-C
M 632 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 640 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 645 function call with no prior declaration. CERT EXP37-C
M 645 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 654 function call with no prior declaration. CERT EXP37-C
M 654 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 659 function call with no prior declaration. CERT EXP37-C
M 659 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 672 Value is not of appropriate type. : unsigned int int sp -> s_buf [ sp -> s_len CERT INT01-C,INT02-C,INT07-C
M 683 Modification of string literal. CERT STR05-C,STR30-C
M 683 Assignment operation in expression. CERT PRE31-C,EXP30-C,EXP31-C,FIO41-C
M 683 function call with no prior declaration. CERT EXP37-C
M 683 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 684 Modification of string literal. CERT STR05-C,STR30-C
M 685 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 687 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 690 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 690 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 690 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 694 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 699 function call with no prior declaration. CERT EXP37-C
M 699 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 700 Value is not of appropriate type. : unsigned int int sp -> s_buf [ sp -> s_len CERT INT01-C,INT02-C,INT07-C
M 704 Value is not of appropriate type. : bool signed char sp -> s_len == sizeof ( sp -> s_buf ) CERT INT01-C,INT02-C,INT07-C
M 705 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 713 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 719 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 722 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 727 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 736 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 742 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C

Code Line Violation Standard
M 745 function call with no prior declaration. CERT EXP37-C
M 749 function call with no prior declaration. CERT EXP37-C
M 749 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 753 Assignment operation in expression. CERT PRE31-C,EXP30-C,EXP31-C,FIO41-C
M 757 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 757 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 757 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C


[ Top of Report | Key to Terms | Procedure Table | Contents ]






phase1
(774 to 1036 hoster.c) - FAIL

Standards Violation Summary

Code Line Violation Standard
M 774 Declaration is missing type. CERT DCL31-C
M 796 Assignment operation in expression. CERT PRE31-C,EXP30-C,EXP31-C,FIO41-C
M 796 function call with no prior declaration. CERT EXP37-C
M 796 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 797 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 798 function call with no prior declaration. CERT EXP37-C
M 798 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 802 function call with no prior declaration. CERT EXP37-C
M 802 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 809 Assignment operation in expression. CERT PRE31-C,EXP30-C,EXP31-C,FIO41-C
M 816 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 817 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 818 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 821 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 822 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 823 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 828 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 829 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 830 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 831 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 834 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 834 Value is not of appropriate type. : unsigned int signed char p = buf + strlen ( buf ) CERT INT01-C,INT02-C,INT07-C
M 836 Modification of string literal. CERT STR05-C,STR30-C
M 837 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 837 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 837 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 842 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 844 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 849 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 850 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 863 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 877 function call with no prior declaration. CERT EXP37-C
M 877 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 877 function call with no prior declaration. CERT EXP37-C
M 877 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 877 function call with no prior declaration. CERT EXP37-C
M 877 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 878 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 885 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 888 Assignment operation in expression. CERT PRE31-C,EXP30-C,EXP31-C,FIO41-C
M 888 function call with no prior declaration. CERT EXP37-C
M 888 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 889 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 890 function call with no prior declaration. CERT EXP37-C
M 890 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 893 function call with no prior declaration. CERT EXP37-C
M 893 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 894 function call with no prior declaration. CERT EXP37-C
M 894 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 895 function call with no prior declaration. CERT EXP37-C

Code Line Violation Standard
M 895 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 896 function call with no prior declaration. CERT EXP37-C
M 896 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 897 function call with no prior declaration. CERT EXP37-C
M 897 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 903 Array index not unsigned. CERT ARR30-C
M 903 Deprecated usage of ++ or -- operators found. CERT EXP30-C,EXP31-C
M 903 Value is not of appropriate type. : unsigned int int av [ ac ++ CERT INT01-C,INT02-C,INT07-C
M 904 Modification of string literal. CERT STR05-C,STR30-C
M 904 Array index not unsigned. CERT ARR30-C
M 904 Deprecated usage of ++ or -- operators found. CERT EXP30-C,EXP31-C
M 904 Value is not of appropriate type. : unsigned int int av [ ac ++ CERT INT01-C,INT02-C,INT07-C
M 906 Modification of string literal. CERT STR05-C,STR30-C
M 906 Array index not unsigned. CERT ARR30-C
M 906 Deprecated usage of ++ or -- operators found. CERT EXP30-C,EXP31-C
M 906 Value is not of appropriate type. : unsigned int int av [ ac ++ CERT INT01-C,INT02-C,INT07-C
M 907 Modification of string literal. CERT STR05-C,STR30-C
M 907 Array index not unsigned. CERT ARR30-C
M 907 Deprecated usage of ++ or -- operators found. CERT EXP30-C,EXP31-C
M 907 Value is not of appropriate type. : unsigned int int av [ ac ++ CERT INT01-C,INT02-C,INT07-C
M 916 Modification of string literal. CERT STR05-C,STR30-C
M 916 Array index not unsigned. CERT ARR30-C
M 916 Deprecated usage of ++ or -- operators found. CERT EXP30-C,EXP31-C
M 916 Value is not of appropriate type. : unsigned int int av [ ac ++ CERT INT01-C,INT02-C,INT07-C
M 919 Modification of string literal. CERT STR05-C,STR30-C
M 919 Array index not unsigned. CERT ARR30-C
M 919 Deprecated usage of ++ or -- operators found. CERT EXP30-C,EXP31-C
M 919 Value is not of appropriate type. : unsigned int int av [ ac ++ CERT INT01-C,INT02-C,INT07-C
M 921 Array index not unsigned. CERT ARR30-C
M 921 Value is not of appropriate type. : unsigned int int av [ ac CERT INT01-C,INT02-C,INT07-C
M 922 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 922 Array index not unsigned. CERT ARR30-C
M 922 Value is not of appropriate type. : unsigned int int fprintf ( stderr , "av[%d]=\"%s\" " , ac , av [ ac CERT INT01-C,INT02-C,INT07-C
M 923 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 926 function call with no prior declaration. CERT EXP37-C
M 926 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 927 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 928 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 969 function call with no prior declaration. CERT EXP37-C
M 969 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 970 function call with no prior declaration. CERT EXP37-C
M 970 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 971 function call with no prior declaration. CERT EXP37-C
M 971 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 987 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 990 Assignment operation in expression. CERT PRE31-C,EXP30-C,EXP31-C,FIO41-C
M 990 function call with no prior declaration. CERT EXP37-C
M 990 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 994 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 1018 function call with no prior declaration. CERT EXP37-C

Code Line Violation Standard
M 1018 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 1019 function call with no prior declaration. CERT EXP37-C
M 1019 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 1020 function call with no prior declaration. CERT EXP37-C
M 1020 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 1027 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 1027 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 1027 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 1029 function call with no prior declaration. CERT EXP37-C
M 1029 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 1031 function call with no prior declaration. CERT EXP37-C
M 1031 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 1033 function call with no prior declaration. CERT EXP37-C
M 1033 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 1034 Assignment operation in expression. CERT PRE31-C,EXP30-C,EXP31-C,FIO41-C


[ Top of Report | Key to Terms | Procedure Table | Contents ]






rexec
(72 to 137 pvmwinrexec.c) - FAIL

Standards Violation Summary

Code Line Violation Standard
M 81 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 85 function call with no prior declaration. CERT EXP37-C
M 85 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 86 function call with no prior declaration. CERT EXP37-C
M 86 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 91 function call with no prior declaration. CERT EXP37-C
M 91 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 95 Modification of string literal. CERT STR05-C,STR30-C
M 103 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 107 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 107 function call with no prior declaration. CERT EXP37-C
M 117 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 121 function call with no prior declaration. CERT EXP37-C
M 121 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 122 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 122 function call with no prior declaration. CERT EXP37-C
M 134 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C


[ Top of Report | Key to Terms | Procedure Table | Contents ]






GetPassword
(140 to 199 pvmwinrexec.c) - FAIL

Standards Violation Summary

Code Line Violation Standard
M 148 function call with no prior declaration. CERT EXP37-C
M 148 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 152 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 152 function call with no prior declaration. CERT EXP37-C
M 156 function call with no prior declaration. CERT EXP37-C
M 156 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 160 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 160 function call with no prior declaration. CERT EXP37-C
M 164 function call with no prior declaration. CERT EXP37-C
M 164 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 166 function call with no prior declaration. CERT EXP37-C
M 166 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 167 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 167 function call with no prior declaration. CERT EXP37-C
M 173 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 175 function call with no prior declaration. CERT EXP37-C
M 175 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 177 function call with no prior declaration. CERT EXP37-C
M 177 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 180 function call with no prior declaration. CERT EXP37-C
M 180 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 182 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 184 function call with no prior declaration. CERT EXP37-C
M 184 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 187 function call with no prior declaration. CERT EXP37-C
M 187 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 188 function call with no prior declaration. CERT EXP37-C
M 188 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 190 Assignment operation in expression. CERT PRE31-C,EXP30-C,EXP31-C,FIO41-C
M 190 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 191 Modification of string literal. CERT STR05-C,STR30-C
M 194 Modification of string literal. CERT STR05-C,STR30-C
M 194 Assignment operation in expression. CERT PRE31-C,EXP30-C,EXP31-C,FIO41-C
M 194 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 195 Modification of string literal. CERT STR05-C,STR30-C
M 198 Pointer assignment to wider scope. CERT DCL30-C,MEM36-C


[ Top of Report | Key to Terms | Procedure Table | Contents ]






PassOutput
(202 to 214 pvmwinrexec.c) - FAIL

Standards Violation Summary

Code Line Violation Standard
M 208 function call with no prior declaration. CERT EXP37-C
M 208 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 210 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 210 function call with no prior declaration. CERT EXP37-C


[ Top of Report | Key to Terms | Procedure Table | Contents ]






PassOutputThread
(217 to 262 pvmwinrexec.c) - FAIL

Standards Violation Summary

Code Line Violation Standard
M 227 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 229 Assignment operation in expression. CERT PRE31-C,EXP30-C,EXP31-C,FIO41-C
M 229 function call with no prior declaration. CERT EXP37-C
M 229 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 229 Array index not unsigned. CERT ARR30-C
M 229 Value is not of appropriate type. : unsigned int int ( count = recv ( sIO , & buf [ i CERT INT01-C,INT02-C,INT07-C
M 233 Modification of string literal. CERT STR05-C,STR30-C
M 233 Array index not unsigned. CERT ARR30-C
M 233 Value is not of appropriate type. : unsigned int int buf [ i CERT INT01-C,INT02-C,INT07-C
M 235 Assignment operation in expression. CERT PRE31-C,EXP30-C,EXP31-C,FIO41-C
M 235 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 236 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 244 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 244 function call with no prior declaration. CERT EXP37-C
M 250 function call with no prior declaration. CERT EXP37-C
M 250 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 251 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 251 function call with no prior declaration. CERT EXP37-C
M 257 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 257 free parameter is not heap item. CERT MEM34-C
M 259 function call with no prior declaration. CERT EXP37-C
M 259 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C


[ Top of Report | Key to Terms | Procedure Table | Contents ]






PassError
(265 to 277 pvmwinrexec.c) - FAIL

Standards Violation Summary

Code Line Violation Standard
M 271 function call with no prior declaration. CERT EXP37-C
M 271 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 273 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 273 function call with no prior declaration. CERT EXP37-C


[ Top of Report | Key to Terms | Procedure Table | Contents ]






PassErrorThread
(279 to 314 pvmwinrexec.c) - FAIL

Standards Violation Summary

Code Line Violation Standard
M 286 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 288 Assignment operation in expression. CERT PRE31-C,EXP30-C,EXP31-C,FIO41-C
M 288 function call with no prior declaration. CERT EXP37-C
M 288 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 289 function call with no prior declaration. CERT EXP37-C
M 289 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 290 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 290 function call with no prior declaration. CERT EXP37-C
M 297 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 297 function call with no prior declaration. CERT EXP37-C
M 303 function call with no prior declaration. CERT EXP37-C
M 303 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 304 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 304 function call with no prior declaration. CERT EXP37-C
M 311 function call with no prior declaration. CERT EXP37-C
M 311 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C


[ Top of Report | Key to Terms | Procedure Table | Contents ]






MyOpenService
(317 to 422 pvmwinrexec.c) - FAIL

Standards Violation Summary

Code Line Violation Standard
M 328 function call with no prior declaration. CERT EXP37-C
M 328 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 329 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 329 function call with no prior declaration. CERT EXP37-C
M 333 function call with no prior declaration. CERT EXP37-C
M 333 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 333 function call with no prior declaration. CERT EXP37-C
M 333 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 334 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 334 function call with no prior declaration. CERT EXP37-C
M 337 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 339 function call with no prior declaration. CERT EXP37-C
M 339 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 340 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 344 function call with no prior declaration. CERT EXP37-C
M 344 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 346 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 346 function call with no prior declaration. CERT EXP37-C
M 351 function call with no prior declaration. CERT EXP37-C
M 351 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 353 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 353 function call with no prior declaration. CERT EXP37-C
M 358 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 358 Casting operation on a pointer. CERT EXP11-C,EXP36-C,INT11-C
M 362 Assignment operation in expression. CERT PRE31-C,EXP30-C,EXP31-C,FIO41-C
M 362 function call with no prior declaration. CERT EXP37-C
M 362 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 363 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 363 function call with no prior declaration. CERT EXP37-C
M 368 function call with no prior declaration. CERT EXP37-C
M 368 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 368 Casting operation on a pointer. CERT EXP11-C,EXP36-C,INT11-C
M 369 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 369 function call with no prior declaration. CERT EXP37-C
M 374 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 375 function call with no prior declaration. CERT EXP37-C
M 375 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 379 Assignment operation in expression. CERT PRE31-C,EXP30-C,EXP31-C,FIO41-C
M 379 function call with no prior declaration. CERT EXP37-C
M 379 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 380 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 380 function call with no prior declaration. CERT EXP37-C
M 385 function call with no prior declaration. CERT EXP37-C
M 385 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 385 Casting operation on a pointer. CERT EXP11-C,EXP36-C,INT11-C
M 386 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 386 function call with no prior declaration. CERT EXP37-C
M 388 function call with no prior declaration. CERT EXP37-C
M 388 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 392 function call with no prior declaration. CERT EXP37-C

Code Line Violation Standard
M 392 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 393 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 393 function call with no prior declaration. CERT EXP37-C
M 395 function call with no prior declaration. CERT EXP37-C
M 395 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 400 function call with no prior declaration. CERT EXP37-C
M 400 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 400 Casting operation on a pointer. CERT EXP11-C,EXP36-C,INT11-C
M 401 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 401 function call with no prior declaration. CERT EXP37-C
M 403 function call with no prior declaration. CERT EXP37-C
M 403 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 407 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 407 function call with no prior declaration. CERT EXP37-C
M 412 Assignment operation in expression. CERT PRE31-C,EXP30-C,EXP31-C,FIO41-C
M 412 function call with no prior declaration. CERT EXP37-C
M 412 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 412 Casting operation on a pointer. CERT EXP11-C,EXP36-C,INT11-C
M 414 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 414 function call with no prior declaration. CERT EXP37-C
M 416 function call with no prior declaration. CERT EXP37-C
M 416 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 420 function call with no prior declaration. CERT EXP37-C
M 420 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C


[ Top of Report | Key to Terms | Procedure Table | Contents ]






Cleanup
(424 to 436 pvmwinrexec.c) - FAIL

Standards Violation Summary

Code Line Violation Standard
M 427 function call with no prior declaration. CERT EXP37-C
M 427 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 431 function call with no prior declaration. CERT EXP37-C
M 431 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 435 function call with no prior declaration. CERT EXP37-C
M 435 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C


[ Top of Report | Key to Terms | Procedure Table | Contents ]






SendZString
(439 to 442 pvmwinrexec.c) - FAIL

Standards Violation Summary

Code Line Violation Standard
M 441 function call with no prior declaration. CERT EXP37-C
M 441 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C


[ Top of Report | Key to Terms | Procedure Table | Contents ]






GetErrString
(445 to 463 pvmwinrexec.c) - FAIL

Standards Violation Summary

Code Line Violation Standard
M 451 function call with no prior declaration. CERT EXP37-C
M 451 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 454 Deprecated usage of ++ or -- operators found. CERT EXP30-C,EXP31-C


[ Top of Report | Key to Terms | Procedure Table | Contents ]






rresvport
(61 to 85 pvmwinrsh.c) - FAIL

Standards Violation Summary

Code Line Violation Standard
M 69 function call with no prior declaration. CERT EXP37-C
M 69 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 76 function call with no prior declaration. CERT EXP37-C
M 76 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 77 function call with no prior declaration. CERT EXP37-C
M 77 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 77 Casting operation on a pointer. CERT EXP11-C,EXP36-C,INT11-C
M 80 function call with no prior declaration. CERT EXP37-C
M 80 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 83 function call with no prior declaration. CERT EXP37-C
M 83 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C


[ Top of Report | Key to Terms | Procedure Table | Contents ]






sendsocket
(88 to 93 pvmwinrsh.c) - FAIL

Standards Violation Summary

Code Line Violation Standard
M 91 function call with no prior declaration. CERT EXP37-C
M 91 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 92 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C


[ Top of Report | Key to Terms | Procedure Table | Contents ]






receivesocket
(100 to 131 pvmwinrsh.c) - FAIL

Standards Violation Summary

Code Line Violation Standard
M 107 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 108 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 109 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 110 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 112 Assignment operation in expression. CERT PRE31-C,EXP30-C,EXP31-C,FIO41-C
M 112 function call with no prior declaration. CERT EXP37-C
M 112 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 113 Array index not unsigned. CERT ARR30-C
M 113 Value is not of appropriate type. : unsigned int int b [ bufflen CERT INT01-C,INT02-C,INT07-C
M 114 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 117 Assignment operation in expression. CERT PRE31-C,EXP30-C,EXP31-C,FIO41-C
M 117 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 118 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 119 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 125 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 125 function call with no prior declaration. CERT EXP37-C
M 126 function call with no prior declaration. CERT EXP37-C
M 126 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C


[ Top of Report | Key to Terms | Procedure Table | Contents ]






verify_hostname
(134 to 151 pvmwinrsh.c) - FAIL

Standards Violation Summary

Code Line Violation Standard
M 137 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 138 function call with no prior declaration. CERT EXP37-C
M 138 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 142 function call with no prior declaration. CERT EXP37-C
M 142 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 144 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 147 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 147 Casting operation on a pointer. CERT EXP11-C,EXP36-C,INT11-C


[ Top of Report | Key to Terms | Procedure Table | Contents ]






initSocket
(158 to 186 pvmwinrsh.c) - FAIL

Standards Violation Summary

Code Line Violation Standard
M 162 function call with no prior declaration. CERT EXP37-C
M 162 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 165 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 167 function call with no prior declaration. CERT EXP37-C
M 167 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 169 function call with no prior declaration. CERT EXP37-C
M 169 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 176 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 178 function call with no prior declaration. CERT EXP37-C
M 178 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 178 Casting operation on a pointer. CERT EXP11-C,EXP36-C,INT11-C
M 180 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 183 function call with no prior declaration. CERT EXP37-C
M 183 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 183 Casting operation on a pointer. CERT EXP11-C,EXP36-C,INT11-C
M 185 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 174 Actual and formal parameters inconsistent (MR). CERT EXP37-C


[ Top of Report | Key to Terms | Procedure Table | Contents ]






initErrSocket
(193 to 215 pvmwinrsh.c) - FAIL

Standards Violation Summary

Code Line Violation Standard
M 201 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 205 function call with no prior declaration. CERT EXP37-C
M 205 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 205 Casting operation on a pointer. CERT EXP11-C,EXP36-C,INT11-C
M 207 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 210 function call with no prior declaration. CERT EXP37-C
M 210 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 210 Casting operation on a pointer. CERT EXP11-C,EXP36-C,INT11-C
M 212 function call with no prior declaration. CERT EXP37-C
M 212 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 213 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C


[ Top of Report | Key to Terms | Procedure Table | Contents ]






do_command
(222 to 249 pvmwinrsh.c) - FAIL

Standards Violation Summary

Code Line Violation Standard
M 231 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 232 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 232 Signed/unsigned conversion without cast. : int unsigned int cmdbufflen = strlen CERT INT02-C,INT31-C,STR34-C
M 234 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 235 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 235 Signed/unsigned conversion without cast. : int unsigned int cmdbufflen += strlen CERT INT02-C,INT31-C,STR34-C
M 237 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 238 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 238 Signed/unsigned conversion without cast. : int unsigned int cmdbufflen += strlen CERT INT02-C,INT31-C,STR34-C
M 240 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 241 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 241 Signed/unsigned conversion without cast. : int unsigned int cmdbufflen += strlen CERT INT02-C,INT31-C,STR34-C


[ Top of Report | Key to Terms | Procedure Table | Contents ]






clientThread
(252 to 276 pvmwinrsh.c) - FAIL

Standards Violation Summary

Code Line Violation Standard
M 260 function call with no prior declaration. CERT EXP37-C
M 260 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 263 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 270 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 272 function call with no prior declaration. CERT EXP37-C
M 272 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 273 function call with no prior declaration. CERT EXP37-C
M 273 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C


[ Top of Report | Key to Terms | Procedure Table | Contents ]






th_start
(281 to 301 pvmwinrsh.c) - FAIL

Standards Violation Summary

Code Line Violation Standard
M 287 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 290 function call with no prior declaration. CERT EXP37-C
M 290 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 291 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 296 function call with no prior declaration. CERT EXP37-C
M 296 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 299 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C


[ Top of Report | Key to Terms | Procedure Table | Contents ]






th_stop
(304 to 322 pvmwinrsh.c) - FAIL

Standards Violation Summary

Code Line Violation Standard
M 307 function call with no prior declaration. CERT EXP37-C
M 307 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 308 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 309 function call with no prior declaration. CERT EXP37-C
M 309 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 313 function call with no prior declaration. CERT EXP37-C
M 313 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 316 function call with no prior declaration. CERT EXP37-C
M 316 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 317 function call with no prior declaration. CERT EXP37-C
M 317 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 319 function call with no prior declaration. CERT EXP37-C
M 319 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C


[ Top of Report | Key to Terms | Procedure Table | Contents ]






rsh
(325 to 345 pvmwinrsh.c) - FAIL

Standards Violation Summary

Code Line Violation Standard
M 329 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 330 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 331 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 331 function call with no prior declaration. CERT EXP37-C
M 334 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C
M 343 Procedure call has no prototype and no defn. CERT DCL07-C,EXP37-C


[ Top of Report | Key to Terms | Procedure Table | Contents ]




Key to Terms


Standards violations for procedures are printed in tables with code markers as follows:


Code (Line) Violation Standard
M (Source line number) [Text of Mandatory standard] [Appropriate rule reference]
C   [Text of Checking standard]  
O   [Text of Optional standard]  
[Source: Text of line from Source file]


                         Checking standards are considered mandatory but individual instances may be overridden by adding annotations to the source code
                         Optional standards provide additional quality criteria but may be violated

                         For some standards violations, additional information is provided in results tables
                         Note that source lines do not show macro expansions

                         "Off" in Summary tables indicates that a standard is switched off in the pen.dat file
                         "MR" in Summary tables indicates a MISRA Restricted standard which cannot be checked without the MISRA licence option.


A summary is given of the pass/fail result of each program component as follows:


Components which pass all standards are marked: Pass
Components which fail only Optional standards are marked: Conditional Pass
Components which fail on insufficient comments only are marked: Comment FAIL
Components which violate Mandatory standards are marked: FAIL



Procedure Results table breakdown (Example Only)


Unique Violations    
     
65 - 150
35 - 39 -



                         The Violation density for a function is the number of violations per reformatted line, expressed as a percentage.
                         It is an indication of code quality.

                         Functions with a high violation density are likely to be smaller functions with a large number of violations.

                         Lower density may indicate larger functions with fewer violations.

                                        (nViols / nRefLines) x 100

                         where:

                                        nViols = number of standard violations in a function.

                         and:

                                        nRefLines = number of reformatted lines in a function.

                         The unique standards failure ratio is an indication of variety of standards violations in a module.

                         Thus a function containing one instance of several different standards will have a high ratio,
                         while a function that has violated only one standards will have a low ratio.


[ Top of Report | Procedure Table | Contents ]


End of Code Review Report

Copyright © 2009 Liverpool Data Research Associates